IFC-758 Add roles, groups and permissions in demo data #4587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
group/backend
CodSpeed Performance ReportMerging #4587 will not alter performanceComparing Summary
|
gmazoyer
force-pushed
the
gma-20241009-ifc758
branch
4 times, most recently
from
9a93cb0
to
3f82434
Compare
gmazoyer
force-pushed
the
gma-20241009-ifc758
branch
from
3f82434
to
1b8426b
Compare
gmazoyer
force-pushed
the
gma-20241009-ifc758
branch
from
1b8426b
to
9f37b6c
Compare
gmazoyer
force-pushed
the
gma-20241009-ifc758
branch
3 times, most recently
from
6b934b2
to
826bc07
Compare
gmazoyer
force-pushed
the
gma-20241009-ifc758
branch
from
826bc07
to
a6f7af2
Compare
github-actions
bot
added
the
type/documentation
ogenstad
approved these changes
Oct 29, 2024
| except NodeNotFoundError: | ||
| obj = await client.create(branch=branch, kind="CoreObjectPermission", data=p.model_dump()) | ||
| batch.add(task=obj.save, node=obj) | ||
| store.set(key=name, node=obj) |
There was a problem hiding this comment.
We could use upsert mutations here to make it a bit easier to read when creating or ensuring that these exist. Not a blocker for now but perhaps an improvement for the next iteration. Do we need to create the global permissions as those should be created automatically?
They should be automatically created on infrahub init.
gmazoyer
force-pushed
the
gma-20241009-ifc758
branch
from
94bdf09
to
0e8b3bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.